Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests for the M2E-PDE connector console printout handler #1813

Merged

Conversation

HannesWell
Copy link
Contributor

@HannesWell HannesWell commented Aug 24, 2024

And clean-up ConsoleTest.

The ConsoleTest.testConsole_debuggerAttachmentAndLinkAlignmentAndBehavior_tychoProject failed because the test-case used the outdated Tycho version 3.0.0, which seems to have a dependency that pulls in apache commons-parent version 35 that is considered as invalid by recent maven versions:

org\apache\commons\commons-parent\35\commons-parent-35.pom:
UTF-8 BOM plus xml decl of ISO-8859-1 is incompatible (position: START_DOCUMENT seen <?xml version="1.0" encoding="ISO-8859-1"... @1:42)

Copy link

github-actions bot commented Aug 24, 2024

Test Results

  214 files  ±0    214 suites  ±0   16m 49s ⏱️ - 3m 10s
  665 tests ±0    654 ✅ +1  10 💤 ±0  1 ❌  - 1 
1 330 runs  ±0  1 309 ✅ +2  20 💤 ±0  1 ❌  - 2 

For more details on these failures, see this check.

Results for commit 05e51bc. ± Comparison against base commit fc87858.

♻️ This comment has been updated with latest results.

and clean-up ConsoleTest.

The 'ConsoleTest.testConsole_debuggerAttachmentAndLinkAlignmentAndBehavior_tychoProject'
failed because the test-case used the out-dated Tycho version 3.0.0,
which seems to have a dependency that pulls in Apache's 'commons-parent'
version 35 that is considered as invalid by recent Maven versions:

org\apache\commons\commons-parent\35\commons-parent-35.pom:
UTF-8 BOM plus xml decl of ISO-8859-1 is incompatible (position:
START_DOCUMENT seen <?xml version="1.0" encoding="ISO-8859-1"... @1:42)
@HannesWell HannesWell force-pushed the fix-failing-m2e.pde.connector.tests branch from 985d9b2 to 05e51bc Compare August 24, 2024 16:46
@HannesWell
Copy link
Contributor Author

Great. The ConsoleTest.testConsole_debuggerAttachmentAndLinkAlignmentAndBehavior_tychoProject is fixed, the remaining failures are for a follow-up.

@HannesWell HannesWell merged commit 08f1c7c into eclipse-m2e:master Aug 24, 2024
5 of 7 checks passed
@HannesWell HannesWell deleted the fix-failing-m2e.pde.connector.tests branch August 24, 2024 17:22
@HannesWell HannesWell added this to the 2.6.2 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant